Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to v19.24.6 #12

Closed
wants to merge 1 commit into from
Closed

Bump to v19.24.6 #12

wants to merge 1 commit into from

Conversation

SfinxCZ
Copy link
Contributor

@SfinxCZ SfinxCZ commented Sep 4, 2024

dlib version bump to v19.24.6

@SfinxCZ
Copy link
Contributor Author

SfinxCZ commented Sep 5, 2024

Hello @alesanfra,
could you please check if this version bump is ok and if so, merge and start the release?

This version bump is primarily to support numpy 2.x.

Thanks a lot

@SfinxCZ SfinxCZ closed this Sep 10, 2024
@alesanfra
Copy link
Owner

Hi @SfinxCZ,

I'm sorry for the late reply. The PR looks good to me, but I noticed that the build commit is still 19.24.2, not the 19.24.6. I suspect that the step Checkout build commit doesn't work any longer, but I don't know why. You can check yourself, in that step you'll find the log HEAD is now at 39749fb tag v19.24.2, which is incorrect.
Unfortunately I don't have spare time to investigate this issue in the coming weeks, if you can investigate yourself and open a PR would great, and of course I'll bet happy to merge it ASAP.
A dirty workaround would be to update the submodules to point to tag v19.24.6; this way, even if that build step is broken, the pipeline should build the correct version.

Thank you for your interest in this project, I hope to hear from you soon.

Alessio

@alesanfra alesanfra reopened this Sep 15, 2024
@alesanfra alesanfra self-requested a review September 15, 2024 16:58
@alesanfra alesanfra added bug Something isn't working enhancement New feature or request labels Sep 15, 2024
@SfinxCZ
Copy link
Contributor Author

SfinxCZ commented Sep 25, 2024

Its strange, it seems that the checkout action fetches incorrect commit
Instead of head from my fork, it fetches the head from the master of this repository:

From https://github.com/alesanfra/dlib-wheels
   * [new ref]         041c93f2c23b7ea2fc1bdbdc75d3663cdd08e6dd -> origin/master

I will try to close this MR and create new one, lets see if it will fix the issue.

@SfinxCZ SfinxCZ closed this Sep 25, 2024
@SfinxCZ SfinxCZ mentioned this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants